Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1476965

Re: [PATCH v2] bcma: use of_dma_configure() to set initial dma mask

From Rafał Miłecki <zajec5@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] bcma: use of_dma_configure() to set initial dma mask
Date 2016-09-05 23:40 +0200
Message-ID <se9Mu-Z5-27@gated-at.bofh.it> (permalink)
References <rdCzo-5z7-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 17 March 2016 at 10:39, Arnd Bergmann <arnd@arndb.de> wrote:
> While fixing another bug, I noticed that bcma manually sets up
> a dma_mask pointer for its child devices. We have a generic
> helper for that now, which should be able to cope better with
> any variations that might be needed to deal with cache coherency,
> unusual DMA address offsets, iommus, or limited DMA masks, none
> of which are currently handled here.
>
> This changes the core to use the of_dma_configure(), like
> we do for platform devices that are probed directly from
> DT.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I applied this patch and tested on BCM47081 based device. I still got
bgmac working which surely uses DMA. There is only 1 ARM wireless SoC
using bcma (BCM47198) but its WiFi core isn't supported by b43.

Any tips what else to test? SPI core/driver doesn't use DMA. Maybe
NAND core does, but we don't use it.

-- 
Rafał

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2] bcma: use of_dma_configure() to set initial dma mask Rafał Miłecki <zajec5@gmail.com> - 2016-09-05 23:40 +0200
  Re: [PATCH v2] bcma: use of_dma_configure() to set initial dma mask Arnd Bergmann <arnd@arndb.de> - 2016-09-06 11:40 +0200

csiph-web