Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1476054

Re: [PATCH] ARM: LPAE: initialize cachepolicy correctly

Show all headers | View raw

On 2016-09-04 15:09, Russell King - ARM Linux wrote:
> On Sat, Sep 03, 2016 at 10:33:31PM -0700, Stefan Agner wrote:
>> The cachepolicy variable gets initialized using a masked pmd
>> So far, the pmd has been masked with flags valid for the 2-page
>> table format. In the LPAE case, this lead to a wrong assumption
>> of what the initial cachepolicy has been used. Later a check
>> forces the cache policy to writealloc and prints the following
>> warning:
>> Forcing write-allocate cache policy for SMP
>>
>> This patch uses PMD_SECT_WBWA to mask all cache setting flags.
>> The define represents the complete mask of the cache relevant
>> flags for both page table formats.
> 
> PMD_SECT_WBWA is just one possible combination, it's not a bit-mask.
> We need a new definition.

Agreed, it just happens to be the same as the bit-mask in both
page-table layouts.

Does PMD_SECT_CACHE_MASK sounds like a reasonable identifier for it?

--
Stefan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: LPAE: initialize cachepolicy correctly Stefan Agner <stefan@agner.ch> - 2016-09-04 07:50 +0200
  Re: [PATCH] ARM: LPAE: initialize cachepolicy correctly Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-05 00:10 +0200
    Re: [PATCH] ARM: LPAE: initialize cachepolicy correctly Stefan Agner <stefan@agner.ch> - 2016-09-05 01:40 +0200
      Re: [PATCH] ARM: LPAE: initialize cachepolicy correctly Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-05 18:30 +0200

csiph-web