Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473244
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static |
| Date | 2016-08-31 12:10 +0200 |
| Message-ID | <scaD0-13d-7@gated-at.bofh.it> (permalink) |
| References | <sc9GV-uN-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday, August 31, 2016 5:05:19 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/phy/tegra/xusb.c:104:5: warning: no previous prototype for 'tegra_xusb_lane_lookup_function' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > Acked-by: Arnd Bergmann <arnd@arndb.de> Same comment as for the other patch, it's better to use "phy: tegra: ..." in the subject for clarity. Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] phy: mark tegra_xusb_lane_lookup_function() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-31 11:10 +0200
Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static Arnd Bergmann <arnd@arndb.de> - 2016-08-31 12:10 +0200
Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static Kishon Vijay Abraham I <kishon@ti.com> - 2016-09-02 14:20 +0200
Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static Thierry Reding <thierry.reding@gmail.com> - 2016-09-01 13:40 +0200
csiph-web