Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1474834
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool |
| Date | 2016-09-02 03:00 +0200 |
| Message-ID | <scKZP-Ip-1@gated-at.bofh.it> (permalink) |
| References | <scHSi-7dg-5@gated-at.bofh.it> <scKQ9-Fd-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2016-09-02 at 00:47 +0000, Bart Van Assche wrote: > On 09/01/16 13:11, Joe Perches wrote: > > > > Assigning an int to a bitfield:1 can lose precision. > > Change the caller argument uses from 1/0 to true/false. > Hello Joe, Hi Bart. > Can you clarify how assigning 0 or 1 to a one-bit bitfield can cause a > loss of precision? There are no existing defects. Using 1/0 is not a loss of precision, it's just changing to use bool avoids potential errors and promotes consistency. Other uses of this function already use true/false.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool Joe Perches <joe@perches.com> - 2016-09-01 23:40 +0200
Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-09-02 02:50 +0200
Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool Joe Perches <joe@perches.com> - 2016-09-02 03:00 +0200
Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-09-02 15:50 +0200
Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool Joe Perches <joe@perches.com> - 2016-09-02 17:50 +0200
Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool Joe Perches <joe@perches.com> - 2016-09-02 18:50 +0200
csiph-web