Groups > linux.kernel > #1472039

Re: [PATCH] arm64: KVM: Save two instructions in __guest_enter()

From	Christoffer Dall <christoffer.dall@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: KVM: Save two instructions in __guest_enter()
Date	2016-08-29 20:20 +0200
Message-ID	<sbzk5-2el-13@gated-at.bofh.it> (permalink)
References	<s4qlz-6S2-15@gated-at.bofh.it> <sa32W-1xi-15@gated-at.bofh.it> <sbwFA-yc-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 29, 2016 at 10:22:06AM -0500, Shanker Donthineni wrote:
> Hi Christoffer,
> 
> This is change may not provide the measurable performance
> improvement, but still we can
> save a few cpu cycles on vCPU context switch and also improves the
> code readability.

I'm not so convinced about saving CPU cycles, but now when I've reviewed
your patch I think it has potential to slightly improve the code.  See
my review of your patch.

-Christoffer

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] arm64: KVM: Save two instructions in __guest_enter() Christoffer Dall <christoffer.dall@linaro.org> - 2016-08-25 15:40 +0200
  Re: [PATCH] arm64: KVM: Save two instructions in __guest_enter() Shanker Donthineni <shankerd@codeaurora.org> - 2016-08-29 17:30 +0200
    Re: [PATCH] arm64: KVM: Save two instructions in __guest_enter() Christoffer Dall <christoffer.dall@linaro.org> - 2016-08-29 20:20 +0200

csiph-web