Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1470602

Re: [PATCH] clk: Simplify __of_clk_get_hw_from_provider()

Show all headers | View raw

On 08/25/2016 10:35 PM, Stephen Boyd wrote:
> __of_clk_get_hw_from_provider() is confusing because it will
> return EPROBE_DEFER if there isn't a ->get() or ->get_hw()
> function pointer in a provider. That's just a bug though, and we
> used to NULL pointer exception when ->get() was missing anyway,
> so let's make this more obvious that they're not optional. The
> assumption is that most providers will implement ->get_hw() so we
> only fallback to the ->get() function if necessary. This
> clarifies the intent and removes any possibility of probe defer
> happening if clk providers are buggy.
> 
> Reported-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: Simplify __of_clk_get_hw_from_provider() Stephen Boyd <sboyd@codeaurora.org> - 2016-08-25 22:40 +0200
  Re: [PATCH] clk: Simplify __of_clk_get_hw_from_provider() Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-08-26 11:00 +0200
  Re: [PATCH] clk: Simplify __of_clk_get_hw_from_provider() Stephen Boyd <sboyd@codeaurora.org> - 2016-08-26 21:30 +0200

csiph-web