Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1558425

Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

Show all headers | View raw

On Fri, Jan 13, 2017 at 10:34:06AM -0300, Javier Martinez Canillas wrote:
> Use the generic helper to get the matched of_device_id .data, instead of
> open coding it.
> 
> The driver was checking if matching the OF node with the driver's OF table
> was failing, but this doesn't make too much sense since this can't happen
> in practice. The fact the probe function was called, means OF registered a
> device with a valid compatible string so a of_device_get_match_data() call
> will always succeed. So just remove this unneeded check.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
> 
> ---
> 
> Changes in v2:
> - Add Laxman's Acked-by tag to patch 2/4.
> - Mention in commit message that an unneeded check for match is removed.
> 
>  drivers/mfd/max77686.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-13 14:40 +0100
  Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data()  helper Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-13 15:20 +0100
  Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-16 07:40 +0100

csiph-web