Re: [PATCH 2/3] cpu: expose pm_qos_resume_latency for each cpu

From	"Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] cpu: expose pm_qos_resume_latency for each cpu
Date	2017-01-11 19:50 +0100
Message-ID	<sYw89-1XP-3@gated-at.bofh.it> (permalink)
References	<sWij0-4TE-7@gated-at.bofh.it> <sWij0-4TE-23@gated-at.bofh.it> <sYmit-4wT-7@gated-at.bofh.it> <sYsed-82P-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 11, 2017 at 3:33 PM, Alex Shi <alex.shi@linaro.org> wrote:
>
>>> >  #include "base.h"
>>> >
>>> > @@ -376,6 +377,9 @@ int register_cpu(struct cpu *cpu, int num)
>>> >
>>> >    per_cpu(cpu_sys_devices, num) = &cpu->dev;
>>> >    register_cpu_under_node(num, cpu_to_node(num));
>>> > +#ifdef CONFIG_CPU_IDLE_GOV_MENU
>>> > +  dev_pm_qos_expose_latency_limit(&cpu->dev, 0);
>>> > +#endif
>> No way to do this without the #ifdef?  That's really not recommended for
>> .c code :(
>>
>
> Hi Greg,
>
> Thanks for comments!
>
> The function dev_pm_qos_expose_latency_limit() is null if no CONFIG_PM.
> So when CONFIG_PM enabled, may we could consider the cpu idle is also
> wanted. In this assumption the #ifdef could be removed. If user want to
> use this feature, she/he should understand the feature only work on menu
> gov only currently. So consider this, I guess we could remove this
> #ifdef. :)

But instead of putting the #ifdef into the function body, you can use
a wrapper function defined to be empty for CONFIG_PM unset.

Thanks,
Rafael

Thread

[PATCH 2/3] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2017-01-05 16:40 +0100
  Re: [PATCH 2/3] cpu: expose pm_qos_resume_latency for each cpu Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-11 09:20 +0100
    Re: [PATCH 2/3] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2017-01-11 15:40 +0100
      Re: [PATCH 2/3] cpu: expose pm_qos_resume_latency for each cpu "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-11 19:50 +0100
        Re: [PATCH 2/3] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2017-01-12 14:20 +0100

csiph-web