Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557416

Re: Support Intel uncore event lists v4

Show all headers | View raw

On Wed, Jan 11, 2017 at 01:54:07PM -0800, Andi Kleen wrote:
> On Wed, Jan 11, 2017 at 10:47:32PM +0100, Jiri Olsa wrote:
> > On Wed, Jan 11, 2017 at 11:52:58AM -0800, Andi Kleen wrote:
> > > > > v1: Initial post
> > > > > v2: Address review feedback. See changelog in commits.
> > > > > v3: Repost. Rebase to latest tree.
> > > > > v4: Rebase. Change DividedBy to generic simple expression parser.
> > > > > Fix refactoring problem that broke git bisect.
> > > > > Address review feedback.
> > > > >
> > > > 
> > > > what's the difference to the post from Jan 03?
> > > 
> > > Jan 03 was v3 I think? 
> > > 
> > > Also I addressed all your review comments (listed in the individual
> > > patches)
> > 
> > 6012     Jan 03 Andi Kleen      (1.5K) Support Intel uncore event lists v4
> > 6421 r   Jan 09 Andi Kleen      (1.5K) Support Intel uncore event lists v4
> > 
> > the messages seem identical
> 
> Hmm I messed up the version number then.  This should be version number
> 5 then.
> 
> It was supposed to fix your review feedback for the earlier series
> and add Acked-by.
> 
> I listed the (minor) changes in the individual patches.
> 
>     perf, tools: Add support for parsing uncore json files
>     v3: Remove extra __maybe_unused
> 
>     perf, tools: Factor out scale conversion code
>     v3: Use ENOMEM, not -1.
> 
> Really only trivial changes at this point, so you only need to read
> the patches you didn't read and ack before.

any chance you'd push the new branch out?

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Support Intel uncore event lists v4 Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 10/11] perf, tools: Support MetricExpr header in JSON event list Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 07/11] perf, tools: Collapse identically named events in perf stat Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 01/11] perf, tools: Factor out scale conversion code Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 09/11] perf, tools: Add a simple expression parser for JSON Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 02/11] perf, tools: Parse eventcode as number in jevents Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 05/11] perf, tools: Support event aliases for non cpu// pmus Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 03/11] perf, tools: Add support for parsing uncore json files Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 08/11] perf, tools: Expand PMU events by prefix match Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  [PATCH 11/11] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:40 +0100
  Re: Support Intel uncore event lists v4 Jiri Olsa <jolsa@redhat.com> - 2017-01-11 20:00 +0100
    Re: Support Intel uncore event lists v4 Andi Kleen <andi@firstfloor.org> - 2017-01-11 21:00 +0100
      Re: Support Intel uncore event lists v4 Jiri Olsa <jolsa@redhat.com> - 2017-01-11 22:50 +0100
        Re: Support Intel uncore event lists v4 Andi Kleen <andi@firstfloor.org> - 2017-01-11 23:00 +0100
          Re: Support Intel uncore event lists v4 Jiri Olsa <jolsa@redhat.com> - 2017-01-12 13:20 +0100
            Re: Support Intel uncore event lists v4 Andi Kleen <andi@firstfloor.org> - 2017-01-12 18:20 +0100

csiph-web