Re: [PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of consistency

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of consistency
Date	2017-01-12 12:20 +0100
Message-ID	<sYLAd-3jp-9@gated-at.bofh.it> (permalink)
References	<sYu6l-Lo-21@gated-at.bofh.it> <sYAYe-54i-7@gated-at.bofh.it> <sYBUe-5BX-11@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Wed, 2017-01-11 at 16:59 -0800, Joe Perches wrote:
> On Wed, 2017-01-11 at 15:57 -0800, Andrew Morton wrote:
> > On Wed, 11 Jan 2017 18:28:07 +0200 Andy Shevchenko <andriy.shevchenk
> > o@linux.intel.com> wrote:
> > 
> > > While resource_size_t is repeating phys_addr_t, allocate %par
> > > specifier for
> > > that type for sake of consistency.
> > > 
> > 
> > I'm struggling to see the value in this.  A more detailed changelog
> > would help, explaining why you think the kernel would benefit from
> > this.
> > 
> > Are there callsites which should be converted?  If so, a patch which
> > does at least some of those would be helpful.
> 
> A resource_size_t isn't a different size than a phys_addr_t.
> Not so far anyway.

Yeah, I know.

> $ git grep typedef.*resource_size_t include
> include/linux/types.h:typedef phys_addr_t resource_size_t;
> 
> Is there an arch that needs a different size?
> If not, why add another case?
> Just to make the kernel larger?

Andrew, Joe, thanks for your comments. That's what I asked for in v1.

Just drop the patch. I got my answers.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of consistency Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-11 17:40 +0100
  Re: [PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of  consistency Andrew Morton <akpm@linux-foundation.org> - 2017-01-12 01:00 +0100
    Re: [PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of  consistency Joe Perches <joe@perches.com> - 2017-01-12 02:00 +0100
      Re: [PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of  consistency Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-12 12:20 +0100

csiph-web