Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents

From	Andi Kleen <andi@firstfloor.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents
Date	2017-01-10 02:20 +0100
Message-ID	<sXTgt-33k-5@gated-at.bofh.it> (permalink)
References	<sVySR-85Q-27@gated-at.bofh.it> <sVz2x-8cw-1@gated-at.bofh.it> <sXqRb-1KB-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> >  	for (f = fields; f->field; f++)
> >  		if (json_streq(map, field, f->field) && nz) {
> > +			/* Handle all variations of 0 encounted in JSON */
> > +			if (json_streq(map, val, "0x00") ||
> > +			     json_streq(map, val, "0x0"))
> > +				return 1;
> 
> how is this related to the patch? also shouldn't it return 0 ?

I removed it now. It avoids some extra umask=0x0 entries, but these
don't hurt.

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents Jiri Olsa <jolsa@redhat.com> - 2017-01-08 20:00 +0100
  Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:20 +0100

csiph-web