Re: [PATCH V5 09/17] blk-throttle: detect completed idle cgroup

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V5 09/17] blk-throttle: detect completed idle cgroup
Date	2017-01-09 21:20 +0100
Message-ID	<sXOAa-gv-21@gated-at.bofh.it> (permalink)
References	<sOKYO-1X6-11@gated-at.bofh.it> <sOKYP-1X6-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Thu, Dec 15, 2016 at 12:33:00PM -0800, Shaohua Li wrote:
> @@ -1660,6 +1671,11 @@ static bool throtl_tg_can_downgrade(struct throtl_grp *tg)
>  	struct throtl_data *td = tg->td;
>  	unsigned long now = jiffies;
>  
> +	if (time_after_eq(now, tg->last_dispatch_time[READ] +
> +					td->throtl_slice) &&
> +	    time_after_eq(now, tg->last_dispatch_time[WRITE] +
> +					td->throtl_slice))
> +		return false;

So, the duration used here is gonna be made explicitly configurable by
a future patch, right?  Might be worthwhile to note that in the
description.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V5 09/17] blk-throttle: detect completed idle cgroup Tejun Heo <tj@kernel.org> - 2017-01-09 21:20 +0100

csiph-web