Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1554556

Re: [PATCH v2] i2c: do not enable fall back to Host Notify by default

Show all headers | View raw

On Wed, Jan 04, 2017 at 08:57:22PM -0800, Dmitry Torokhov wrote:
> Falling back unconditionally to HostNotify as primary client's interrupt
> breaks some drivers which alter their functionality depending on whether
> interrupt is present or not, so let's introduce a board flag telling I2C
> core explicitly if we want wired interrupt or HostNotify-based one:
> I2C_CLIENT_HOST_NOTIFY.
> 
> For DT-based systems we introduce "host-notify" property that we convert
> to I2C_CLIENT_HOST_NOTIFY board flag.
> 
> Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> 
> v1->v2:
> 
> - of_read_property_bool -> of_property_read_bool
> - did not change binding wording to avoit mentioning I2C core because we
>   use the same wording (mentioning I2C core) for wired interrupts
> 
>  Documentation/devicetree/bindings/i2c/i2c.txt |  8 ++++++++

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/i2c/i2c-core.c                        | 17 ++++++++---------
>  include/linux/i2c.h                           |  1 +
>  3 files changed, 17 insertions(+), 9 deletions(-)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] i2c: do not enable fall back to Host Notify by default Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-05 06:00 +0100
  Re: [PATCH v2] i2c: do not enable fall back to Host Notify by default Pali Rohár <pali.rohar@gmail.com> - 2017-01-05 13:40 +0100
  Re: [PATCH v2] i2c: do not enable fall back to Host Notify by default Rob Herring <robh@kernel.org> - 2017-01-09 19:00 +0100
  Re: [PATCH v2] i2c: do not enable fall back to Host Notify by default Wolfram Sang <wsa@the-dreams.de> - 2017-01-12 19:50 +0100
    Re: [PATCH v2] i2c: do not enable fall back to Host Notify by default Dmitry Torokhov <dtor@kernel.org> - 2017-01-12 21:40 +0100

csiph-web