[net-next v1 4/8] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY

From	Murali Karicheri <m-karicheri2@ti.com>
Newsgroups	linux.kernel
Subject	[net-next v1 4/8] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY
Date	2017-01-06 21:40 +0100
Message-ID	<sWJsR-75B-1@gated-at.bofh.it> (permalink)
References	<sWJsR-75B-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Currently to parse phy-handle, driver doesn't check if the interface is
MAC to PHY. This patch add this check for all MAC to PHY interface types
supported by the driver.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/net/ethernet/ti/netcp_ethss.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c
index 7d9e36f..4a64b3e 100644
--- a/drivers/net/ethernet/ti/netcp_ethss.c
+++ b/drivers/net/ethernet/ti/netcp_ethss.c
@@ -2930,7 +2930,9 @@ static int init_slave(struct gbe_priv *gbe_dev, struct gbe_slave *slave,
 	}
 
 	slave->open = false;
-	slave->phy_node = of_parse_phandle(node, "phy-handle", 0);
+	if ((slave->link_interface == SGMII_LINK_MAC_PHY) ||
+	    (slave->link_interface == XGMII_LINK_MAC_PHY))
+		slave->phy_node = of_parse_phandle(node, "phy-handle", 0);
 	slave->port_num = gbe_get_slave_port(gbe_dev, slave->slave_num);
 
 	if (slave->link_interface >= XGMII_LINK_MAC_PHY)
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[net-next v1 4/8] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY Murali Karicheri <m-karicheri2@ti.com> - 2017-01-06 21:40 +0100

csiph-web