Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553111
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] xen: clean up xenbus internal headers |
| Date | 2017-01-06 22:00 +0100 |
| Message-ID | <sWJMd-7eR-7@gated-at.bofh.it> (permalink) |
| References | <sWEjv-3EM-9@gated-at.bofh.it> <sWEjv-3EM-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 01/06/2017 10:05 AM, Juergen Gross wrote:
> The xenbus driver has an awful mixture of internal and global visible
> headers: some of the internal used only stuff is defined in the
> global header include/xen/xenbus.h while some stuff defined in internal
> headers is used by other drivers, too.
>
> Clean this up by moving the external used symbols to
> include/xen/xenbus.h and the symbols used internal only to a new
I think
s/external/externally/
s/internal/internally/
> header drivers/xen/xenbus/xenbus.h
... and remove xenbus_comms.h
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} | 64 ++++++++++++++-----------
> drivers/xen/xenbus/xenbus_client.c | 2 +-
> drivers/xen/xenbus/xenbus_comms.c | 2 +-
> drivers/xen/xenbus/xenbus_comms.h | 51 --------------------
> drivers/xen/xenbus/xenbus_dev_backend.c | 2 +-
> drivers/xen/xenbus/xenbus_dev_frontend.c | 4 +-
> drivers/xen/xenbus/xenbus_probe.c | 3 +-
> drivers/xen/xenbus/xenbus_probe_backend.c | 3 +-
> drivers/xen/xenbus/xenbus_probe_frontend.c | 3 +-
> drivers/xen/xenbus/xenbus_xs.c | 3 +-
> drivers/xen/xenfs/super.c | 2 +-
> drivers/xen/xenfs/xenstored.c | 2 +-
> include/xen/xenbus.h | 12 ++---
> 13 files changed, 52 insertions(+), 101 deletions(-)
> rename drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} (58%)
> delete mode 100644 drivers/xen/xenbus/xenbus_comms.h
>
> diff --git a/drivers/xen/xenbus/xenbus_probe.h b/drivers/xen/xenbus/xenbus.h
> similarity index 58%
> rename from drivers/xen/xenbus/xenbus_probe.h
> rename to drivers/xen/xenbus/xenbus.h
> index c9ec7ca..6a80c1e 100644
> --- a/drivers/xen/xenbus/xenbus_probe.h
> +++ b/drivers/xen/xenbus/xenbus.h
> @@ -1,10 +1,7 @@
> -/******************************************************************************
> - * xenbus_probe.h
> - *
> - * Talks to Xen Store to figure out what devices we have.
> +/*
> + * Private include for xenbus communications.
> *
> * Copyright (C) 2005 Rusty Russell, IBM Corporation
> - * Copyright (C) 2005 XenSource Ltd.
Why is this?
-boris
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] xen: clean up xenbus internal headers Juergen Gross <jgross@suse.com> - 2017-01-06 16:10 +0100
Re: [PATCH 1/3] xen: clean up xenbus internal headers Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-01-06 22:00 +0100
Re: [PATCH 1/3] xen: clean up xenbus internal headers Juergen Gross <jgross@suse.com> - 2017-01-09 08:10 +0100
csiph-web