Re: [PATCH] net: phy: dp83867: fix irq generation

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: phy: dp83867: fix irq generation
Date	2017-01-06 22:00 +0100
Message-ID	<sWJMd-7eR-19@gated-at.bofh.it> (permalink)
References	<sWn8Z-83K-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Thu, 5 Jan 2017 14:48:07 -0600

> For proper IRQ generation by DP83867 phy the INT/PWDN pin has to be
> programmed as an interrupt output instead of a Powerdown input in
> Configuration Register 3 (CFG3), Address 0x001E, bit 7 INT_OE = 1. The
> current driver doesn't do this and as result IRQs will not be generated by
> DP83867 phy even if they are properly configured in DT.
> 
> Hence, fix IRQ generation by properly configuring CFG3.INT_OE bit and
> ensure that Link Status Change (LINK_STATUS_CHNG_INT) and Auto-Negotiation
> Complete (AUTONEG_COMP_INT) interrupt are enabled. After this the DP83867
> driver will work properly in interrupt enabled mode.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: phy: dp83867: fix irq generation Grygorii Strashko <grygorii.strashko@ti.com> - 2017-01-05 21:50 +0100
  Re: [PATCH] net: phy: dp83867: fix irq generation Florian Fainelli <f.fainelli@gmail.com> - 2017-01-05 23:20 +0100
    Re: [PATCH] net: phy: dp83867: fix irq generation Grygorii Strashko <grygorii.strashko@ti.com> - 2017-01-06 18:30 +0100
  Re: [PATCH] net: phy: dp83867: fix irq generation David Miller <davem@davemloft.net> - 2017-01-06 22:00 +0100

csiph-web