Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

From	Timur Tabi <timur@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003
Date	2017-01-06 17:00 +0100
Message-ID	<sWF5U-3ZI-39@gated-at.bofh.it> (permalink)
References	<sTRGh-4dP-1@gated-at.bofh.it> <sTRGh-4dP-3@gated-at.bofh.it> <sTRZD-4zG-1@gated-at.bofh.it> <sWEWe-3VU-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Christopher Covington wrote:
>> > Also, since this can't be changed via the menu, why bother putting it in?
> I put it in in response to review comments asking for the magic number to
> be clarified by a #define or variable. I could not find a suitably shared
> header between the files in question, so I used the Kconfig machinery to
> generate the #define.

I don't think that's the right approach.  Kconfigs are not an 
alternative to header files.  Is the ASID configurable?  If you just put 
some text after the "int" then it because a menu option that the user 
can select and change.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003 Christopher Covington <cov@codeaurora.org> - 2017-01-06 16:50 +0100
  Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003 Timur Tabi <timur@codeaurora.org> - 2017-01-06 17:00 +0100

csiph-web