Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1552894

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

From Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Newsgroups linux.kernel
Subject Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands
Date 2017-01-06 16:50 +0100
Message-ID <sWEWe-3VU-41@gated-at.bofh.it> (permalink)
References (1 earlier) <sUB6q-SS-3@gated-at.bofh.it> <sUQoN-25U-5@gated-at.bofh.it> <sURkS-2H5-33@gated-at.bofh.it> <sUSgV-3hC-5@gated-at.bofh.it> <sWs8G-3cr-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jan 6, 2017 at 7:29 AM, Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>>>>>> "James" == James Bottomley <jejb@linux.vnet.ibm.com> writes:
>
> James> Now that I look at the reviews, each of the reviewers said what
> James> the correct thing to do was: return SAM_STAT_BUSY if SATL
> James> commands are outstanding like the spec says.  You all get
> James> negative brownie points for not insisting on a rework.
>
> James> Does this patch (compile tested only) fix the problems for
> James> everyone?
>
> I also like this approach better.
>
> Broadcom folks: Please comment and test.

Matin, We are fine with this patch. Can we rename function
'set_satl_pending()' name to '_scsih_set_satl_pending()' and can add
headers to this function.

other wise I am OK.

Acked-by: Sreekanth Reddy <Sreekanth.Reddy@broadcom.com>

>
> --
> Martin K. Petersen      Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-01-06 03:10 +0100
  Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands Sreekanth Reddy <sreekanth.reddy@broadcom.com> - 2017-01-06 16:50 +0100
    Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-01-10 06:00 +0100

csiph-web