Re: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand
Date	2017-01-03 10:00 +0100
Message-ID	<sVt6N-3AE-3@gated-at.bofh.it> (permalink)
References	<ralOp-7hm-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sushaanth,

Sorry for the late reply, I'm dequeing old NAND related patches and
found this one.

Is this patch still needed?

On Tue, 8 Mar 2016 14:38:15 +0530
Sushaanth Srirangapathi <sushaanth.s@ti.com> wrote:

> Commit 28c015a9daabe4e ("mtd: davinci-nand: disable subpage write for
> keystone-nand") disables subpage write for Keystone SOCs due to hw
> issues.
> 
> But subpage writes doesn't work even for DaVinci SOCs due to hw issues.
> So set NAND_NO_SUBPAGE_WRITE option for all devices compatible to
> this driver.
> 
> I tested this patch using DA850 board.
> 
> Signed-off-by: Sushaanth Srirangapathi <sushaanth.s@ti.com>
> ---
>  drivers/mtd/nand/davinci_nand.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index 8cb821b..466439c 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -601,11 +601,7 @@ static struct davinci_nand_pdata
>  		    of_property_read_bool(pdev->dev.of_node,
>  			"ti,davinci-nand-use-bbt"))
>  			pdata->bbt_options = NAND_BBT_USE_FLASH;
> -
> -		if (of_device_is_compatible(pdev->dev.of_node,
> -					    "ti,keystone-nand")) {
> -			pdata->options |= NAND_NO_SUBPAGE_WRITE;
> -		}
> +		pdata->options |= NAND_NO_SUBPAGE_WRITE;
>  	}
>  
>  	return dev_get_platdata(&pdev->dev);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mtd: davinci-nand: disable subpage write for  davinci-nand Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-03 10:00 +0100
  Re: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand Sekhar Nori <nsekhar@ti.com> - 2017-01-03 12:40 +0100
    Re: [PATCH] mtd: davinci-nand: disable subpage write for  davinci-nand Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-03 14:20 +0100

csiph-web