Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549478

Re: [PATCH RESEND 10/10] m68k/mac: Replace via-maciisi driver with via-cuda driver

Show all headers | View raw

On Mon, 2 Jan 2017, Geert Uytterhoeven wrote:

> Hi Finn, Ben,
> 
> On Sun, Jan 1, 2017 at 1:56 AM, Finn Thain <fthain@telegraphics.com.au> 
> wrote:
> > Change the device probe test in the via-cuda.c driver so it will load 
> > on Egret-based machines too. Remove the now redundant via-maciisi.c 
> > driver.
> >
> > Tested-by: Stan Johnson <userm57@yahoo.com> Signed-off-by: Finn Thain 
> > <fthain@telegraphics.com.au>
> 
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 

Thanks for your review.

> I guess this will go in with the rest of the series through Ben's 
> macintosh tree?
> 

Most of the recent patches in drivers/macintosh, including my 2015 
submission, commit 2dc710e93c ("macintosh/nvram: Remove as unused"), went 
through Michael's tree. But either tree would be fine with me.

BTW, to my knowledge there is no programmer's reference material for Cuda 
or Egret system controllers (excepting that which seems to be confined to 
Apple Inc). AIUI, Cuda was not part of CHRP. But one could observe all of 
the signalling between CPU and MCU by tracing the VIA I/O lines or doing 
the equivalent in a good emulator -- theoretically, of course. Would this 
be useful to reviewers?

-- 

> > ---
> >  arch/m68k/include/asm/macintosh.h |   2 +-
> >  arch/m68k/mac/config.c            |  18 +-
> >  arch/m68k/mac/misc.c              |  72 +---
> >  drivers/macintosh/Kconfig         |  24 +-
> >  drivers/macintosh/Makefile        |   1 -
> >  drivers/macintosh/adb.c           |   4 -
> >  drivers/macintosh/via-cuda.c      |   8 +-
> >  drivers/macintosh/via-maciisi.c   | 677 --------------------------------------
> >  8 files changed, 30 insertions(+), 776 deletions(-)
> >  delete mode 100644 drivers/macintosh/via-maciisi.c
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 00/10] Replace via-maciisi with via-cuda driver Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
  [PATCH RESEND 04/10] via-cuda: Prevent read buffer overflow Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
  [PATCH RESEND 10/10] m68k/mac: Replace via-maciisi driver with  via-cuda driver Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
    Re: [PATCH RESEND 10/10] m68k/mac: Replace via-maciisi driver with  via-cuda driver Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-02 11:30 +0100
      Re: [PATCH RESEND 10/10] m68k/mac: Replace via-maciisi driver with  via-cuda driver Finn Thain <fthain@telegraphics.com.au> - 2017-01-03 01:40 +0100
  [PATCH RESEND 05/10] via-cuda: Fix re-initialization of reply_ptr and  reading_reply Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
  [PATCH RESEND 08/10] via-cuda: Initialize data_index early and  increment consistently Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
  [PATCH RESEND 02/10] via-cuda: Remove redundant temporary variable Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
  [PATCH RESEND 01/10] via-cuda: Cleanup printk calls Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
  [PATCH RESEND 09/10] via-cuda: Add support for Egret system  controller Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
  [PATCH RESEND 03/10] via-cuda: Add TREQ, TIP and TACK signal helpers Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100
  [PATCH RESEND 07/10] via-cuda: Use spinlock_irq_save/restore instead  of enable/disable_irq Finn Thain <fthain@telegraphics.com.au> - 2017-01-01 02:00 +0100

csiph-web