Re: [PATCH 1/2] drm_fourcc: Add new P010 video format

From	Ville Syrjälä <ville.syrjala@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] drm_fourcc: Add new P010 video format
Date	2017-01-04 17:00 +0100
Message-ID	<sVW8O-6Ds-11@gated-at.bofh.it> (permalink)
References	<sV6Df-4iu-19@gated-at.bofh.it> <sV6Df-4iu-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 02, 2017 at 04:50:03PM +0800, Randy Li wrote:
> P010 is a planar 4:2:0 YUV with interleaved UV plane, 10 bits
> per channel video format. Rockchip's vop support this
> video format(little endian only) as the input video format.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  include/uapi/drm/drm_fourcc.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 9e1bb7f..d2721da 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -119,6 +119,7 @@ extern "C" {
>  #define DRM_FORMAT_NV61		fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */
>  #define DRM_FORMAT_NV24		fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */
>  #define DRM_FORMAT_NV42		fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */
> +#define DRM_FORMAT_P010		fourcc_code('P', '0', '1', '0') /* 2x2 subsampled Cr:Cb plane 10 bits per channel */

We could use a better description of the format here. IIRC there is
10bits of actual data contained in each 16bits. So there should be a
proper comment explaning in which way the bits are stored.

>  
>  /*
>   * 3 plane YCbCr
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] drm_fourcc: Add new P010 video format Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-01-04 17:00 +0100
  Re: [PATCH 1/2] drm_fourcc: Add new P010 video format ayaka <ayaka@soulik.info> - 2017-01-04 17:40 +0100
    Re: [PATCH 1/2] drm_fourcc: Add new P010 video format Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-01-04 17:50 +0100

csiph-web