Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts
Date	2017-01-04 15:50 +0100
Message-ID	<sVV34-5Z1-21@gated-at.bofh.it> (permalink)
References	<sT0LE-36Q-9@gated-at.bofh.it> <sT0LE-36Q-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 2016-12-27 23:16:08, Sergey Senozhatsky wrote:
> Account lost messages in pritk-safe and printk-safe-nmi
> contexts and report those numbers during printk_safe_flush().
> 
> The patch also moves lost message counter to struct
> `printk_safe_seq_buf' instead of having dedicated static
> counters - this simplifies the code.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

I like that the handling is localized in printk_safe.c and that
the warning is printed right after the messages that fit the buffer.

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi  contexts Petr Mladek <pmladek@suse.com> - 2017-01-04 15:50 +0100
  Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi  contexts Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-01-05 02:10 +0100

csiph-web