Re: [PATCH] floppy: replace wrong kmalloc(GFP_USER) with GFP_KERNEL

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] floppy: replace wrong kmalloc(GFP_USER) with GFP_KERNEL
Date	2017-01-04 13:30 +0100
Message-ID	<sVSRA-4Ct-33@gated-at.bofh.it> (permalink)
References	<sVQZs-3pc-53@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 4 Jan 2017, Vlastimil Babka wrote:

> The raw_cmd_copyin() function does a kmalloc() with GFP_USER, although the
> allocated structure is obviously not mapped to userspace, just copied from/to.
> In this case GFP_KERNEL is more appropriate, so let's use it, although in the
> current implementation this does not manifest as any error.
> 
> Reported-by: Matthew Wilcox <mawilcox@linuxonhyperv.com>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] floppy: replace wrong kmalloc(GFP_USER) with GFP_KERNEL Vlastimil Babka <vbabka@suse.cz> - 2017-01-04 11:30 +0100
  Re: [PATCH] floppy: replace wrong kmalloc(GFP_USER) with  GFP_KERNEL Jiri Kosina <jikos@kernel.org> - 2017-01-04 13:30 +0100

csiph-web