Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550456

Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization

Show all headers | View raw

On Mon, 02 Jan 2017 16:50:30 +0100,
Ioan-Adrian Ratiu wrote:
> 
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
(snip)
> @@ -850,7 +850,7 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
>  	/* for playback, submit the URBs now; otherwise, the first hwptr_done
>  	 * updates for all URBs would happen at the same time when starting */
>  	if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK)
> -		ret = start_endpoints(subs, true);
> +		return start_endpoints(subs);

Here you miss the unlock below.

>  
>   unlock:
>  	snd_usb_unlock_shutdown(subs->stream->chip);

... and this must be the reason of the hang up at disconnection, where
the driver ways forever at wait_event() in usb_audio_disconnect().

Could you fix this and resubmit v3?  Other than that, it looks OK.


thanks,

Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] ALSA: Fix usb-audio races Ioan-Adrian Ratiu <adi@adirat.com> - 2017-01-02 16:50 +0100
  [PATCH v2 2/2] ALSA: usb-audio: test EP_FLAG_RUNNING at urb completion Ioan-Adrian Ratiu <adi@adirat.com> - 2017-01-02 16:50 +0100
  [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization Ioan-Adrian Ratiu <adi@adirat.com> - 2017-01-02 17:00 +0100
    Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization Takashi Iwai <tiwai@suse.de> - 2017-01-04 07:30 +0100
      Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization Ioan-Adrian Ratiu <adi@adirat.com> - 2017-01-04 10:20 +0100
  Re: [PATCH v2 0/2] ALSA: Fix usb-audio races Ioan-Adrian Ratiu <adi@adirat.com> - 2017-01-03 08:30 +0100
    Re: [PATCH v2 0/2] ALSA: Fix usb-audio races Ioan-Adrian Ratiu <adi@adirat.com> - 2017-01-03 09:50 +0100
      Re: [PATCH v2 0/2] ALSA: Fix usb-audio races Takashi Iwai <tiwai@suse.de> - 2017-01-03 10:20 +0100

csiph-web