Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation
Date	2017-01-03 20:30 +0100
Message-ID	<sVCWt-2r6-9@gated-at.bofh.it> (permalink)
References	<sOWGC-1t7-35@gated-at.bofh.it> <sV4UN-39U-15@gated-at.bofh.it> <sVeKt-1QB-1@gated-at.bofh.it> <sVil4-4ub-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 02, 2017 at 10:19:29PM +0100, Rafael J. Wysocki wrote:
> On Mon, Jan 2, 2017 at 6:36 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On Mon, Jan 02, 2017 at 12:39:03PM +0530, Viresh Kumar wrote:
> >> On 16-12-16, 10:06, Arnd Bergmann wrote:
> >> > s3c64xx_cpufreq_config_regulator is incorrectly annotated
> >> > as __init, since the caller is also not init:
> >> >
> >> > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator()
> >> >
> >> > With modern gcc versions, the function gets inline, so we don't
> >> > see the warning, this only happens with gcc-4.6 and older.
> >> >
> >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> > ---
> >> >  drivers/cpufreq/s3c64xx-cpufreq.c | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c
> >> > index 176e84cc3991..0cb9040eca49 100644
> >> > --- a/drivers/cpufreq/s3c64xx-cpufreq.c
> >> > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c
> >> > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy,
> >> >  }
> >> >
> >> >  #ifdef CONFIG_REGULATOR
> >> > -static void __init s3c64xx_cpufreq_config_regulator(void)
> >> > +static void s3c64xx_cpufreq_config_regulator(void)
> >> >  {
> >> >     int count, v, i, found;
> >> >     struct cpufreq_frequency_table *freq;
> >>
> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Rafael,
> > Are you going to pick it up?
> 
> I thought I did, didn't I?

Right, you did. I missed that. Thanks!

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Arnd Bergmann <arnd@arndb.de> - 2016-12-16 10:10 +0100
  Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-16 18:00 +0100
  Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Viresh Kumar <viresh.kumar@linaro.org> - 2017-01-02 08:10 +0100
    Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-02 18:40 +0100
      Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-02 22:30 +0100
        Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-03 20:30 +0100

csiph-web