Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549970

Re: [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for TM2

Show all headers | View raw

On Tue, Jan 03, 2017 at 04:57:15PM +0900, Jaechul Lee wrote:
> This patch adds support for the TM2 touch key and led
> functionlity.
> 
> The driver interfaces with userspace through an input device and
> reports KEY_PHONE and KEY_BACK event types. LED brightness can be
> controlled by "/sys/class/leds/tm2-touchkey/brightness".
> 
> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> ---
>  drivers/input/keyboard/Kconfig        |  11 ++
>  drivers/input/keyboard/Makefile       |   1 +
>  drivers/input/keyboard/tm2-touchkey.c | 326 ++++++++++++++++++++++++++++++++++
>  3 files changed, 338 insertions(+)
>  create mode 100644 drivers/input/keyboard/tm2-touchkey.c
> 
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index cbd75cf..72c0ba1 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -666,6 +666,17 @@ config KEYBOARD_TC3589X
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called tc3589x-keypad.
>  
> +config KEYBOARD_TM2_TOUCHKEY
> +	tristate "tm2-touchkey support"
> +	depends on I2C
> +	help
> +	  Say Y here to enable the tm2-touchkey.

The ending full stop is not needed.

> +	  touchkey driver for tm2. This driver can enable
> +	  the interrupt and make input events and control led brightness.

This sentence needs improvements. How about just:
"Beside input device, this driver provides also brightness control for
LEDs on touch keys."

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Add touch key driver support for TM2 Jaechul Lee <jcsing.lee@samsung.com> - 2017-01-03 09:00 +0100
  [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for TM2 Jaechul Lee <jcsing.lee@samsung.com> - 2017-01-03 09:00 +0100
    Re: [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for  TM2 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-03 14:20 +0100
      Re: [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for  TM2 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-03 20:00 +0100
    Re: [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for  TM2 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-03 18:10 +0100
  Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from  each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-03 09:20 +0100
  Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-03 09:30 +0100
    Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from  each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-03 11:00 +0100
      Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-03 12:50 +0100
        Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from  each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-03 13:00 +0100
          Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-03 13:20 +0100
            Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Andi Shyti <andi@etezian.org> - 2017-01-03 15:50 +0100
              Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-03 16:10 +0100
              Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-03 17:10 +0100
                Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-03 18:00 +0100
      Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from  each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-03 11:30 +0100
        Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-03 17:50 +0100
      Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent  from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-03 11:10 +0100

csiph-web