Re: [PATCH 1/3] m68k/mac: Improve NMI handler

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] m68k/mac: Improve NMI handler
Date	2017-01-02 11:30 +0100
Message-ID	<sV82l-5nR-1@gated-at.bofh.it> (permalink)
References	<sV7zj-4VR-9@gated-at.bofh.it> <sV7zj-4VR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Finn,

On Mon, Jan 2, 2017 at 10:53 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> mac_nmi_handler() is useless in its present form and locks up my PowerBook
> 180. Let's throw out the dead code and make it do something useful: print
> a register dump and a stack trace.
>
> mac_debug_handler() is also dead code. Remove it along with its static
> data.

Thanks for your patch!

> --- a/arch/m68k/mac/macints.c
> +++ b/arch/m68k/mac/macints.c
> @@ -127,12 +127,9 @@
>
>  #define SHUTUP_SONIC
>
> -/*
> - * console_loglevel determines NMI handler function
> - */
> +extern void show_registers(struct pt_regs *);

Seems like we do have a declaration in ... <linux/kprobes.h>.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Thread

[PATCH 1/3] m68k/mac: Improve NMI handler Finn Thain <fthain@telegraphics.com.au> - 2017-01-02 11:00 +0100
  Re: [PATCH 1/3] m68k/mac: Improve NMI handler Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-02 11:30 +0100
    Re: [PATCH 1/3] m68k/mac: Improve NMI handler Finn Thain <fthain@telegraphics.com.au> - 2017-01-03 05:40 +0100
      Re: [PATCH 1/3] m68k/mac: Improve NMI handler Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-03 09:20 +0100

csiph-web