Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549061

Re: [PATCH v4 2/4] ARM: da850: don't add the emac clock to the clock lookup table twice

Show all headers | View raw

On Wednesday 07 December 2016 08:52 PM, Bartosz Golaszewski wrote:
> Similarly to the aemif clock - this screws up the linked list of clock
> children. Create a separate clock for mdio inheriting the rate from
> emac_clk.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Applied with change in headline (see comment on 1/4). Also added a 
comment explaining why mdio clk is needed.

> ---
>  arch/arm/mach-davinci/da850.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> index e9d019c..6b1fbac 100644
> --- a/arch/arm/mach-davinci/da850.c
> +++ b/arch/arm/mach-davinci/da850.c
> @@ -319,6 +319,11 @@ static struct clk emac_clk = {
>  	.gpsc		= 1,
>  };
>  

/*
 * In order to avoid adding the emac_clk to the clock lookup table twice (and
 * screwing up the linked list in the process) create a separate clock for
 * mdio inheriting the rate from emac_clk.
 */

> +static struct clk mdio_clk = {
> +	.name		= "mdio",
> +	.parent		= &emac_clk,
> +};

Thanks,
Sekhar

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/4] ARM: da850: don't add the emac clock to the clock  lookup table twice Sekhar Nori <nsekhar@ti.com> - 2017-01-02 10:30 +0100

csiph-web