Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1548381
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/3] cgroup: cosmetic update to cgroup_taskset_add() |
| Date | 2016-12-29 23:20 +0100 |
| Message-ID | <sTRdg-42p-15@gated-at.bofh.it> (permalink) |
| References | <sTRdf-42p-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
cgroup_taskset_add() was using list_add_tail() when for source csets but list_move_tail() for destination. As the operations are gated by list_empty() test, list_move_tail() is equivalent to list_add_tail() here. Use list_add_tail() too for destination csets too. This doesn't cause any functional changes. Signed-off-by: Tejun Heo <tj@kernel.org> --- kernel/cgroup/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index d9d82e9..aed492e 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -1980,8 +1980,8 @@ static void cgroup_taskset_add(struct task_struct *task, if (list_empty(&cset->mg_node)) list_add_tail(&cset->mg_node, &tset->src_csets); if (list_empty(&cset->mg_dst_cset->mg_node)) - list_move_tail(&cset->mg_dst_cset->mg_node, - &tset->dst_csets); + list_add_tail(&cset->mg_dst_cset->mg_node, + &tset->dst_csets); } /** -- 2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations Tejun Heo <tj@kernel.org> - 2016-12-29 23:20 +0100 [PATCH 1/3] cgroup: cosmetic update to cgroup_taskset_add() Tejun Heo <tj@kernel.org> - 2016-12-29 23:20 +0100 [PATCH 3/3] cgroup: call subsys->*attach() only for subsystems which are actually affected by migration Tejun Heo <tj@kernel.org> - 2016-12-29 23:20 +0100 [PATCH 2/3] cgroup: track migration context in cgroup_mgctx Tejun Heo <tj@kernel.org> - 2016-12-29 23:20 +0100
csiph-web