[PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident

From	Bhumika Goyal <bhumirks@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident
Date	2016-12-25 09:10 +0100
Message-ID	<sSc2t-2bl-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The object ident of type watchdog_info structure is not
modified after getting initialized by pikawdt_init. Apart from getting
referenced in init it is also passed as an argument to the function
copy_to_user but this argument is of type const void *. Therefore add
__ro_after_init to its declaration.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/watchdog/pika_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c
index 0cdfee2..e35cf5e 100644
--- a/drivers/watchdog/pika_wdt.c
+++ b/drivers/watchdog/pika_wdt.c
@@ -54,7 +54,7 @@
 	struct timer_list timer;	/* The timer that pings the watchdog */
 } pikawdt_private;
 
-static struct watchdog_info ident = {
+static struct watchdog_info ident __ro_after_init = {
 	.identity	= DRV_NAME,
 	.options	= WDIOF_CARDRESET |
 			  WDIOF_SETTIMEOUT |
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident Bhumika Goyal <bhumirks@gmail.com> - 2016-12-25 09:10 +0100
  Re: [PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident Guenter Roeck <linux@roeck-us.net> - 2016-12-26 11:40 +0100

csiph-web