Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly
Date	2016-12-22 18:30 +0100
Message-ID	<sRflL-3Vq-3@gated-at.bofh.it> (permalink)
References	<sRflL-3Vq-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote:
> The gpiod_get* function family does not want the -gpio suffix.
> Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional.
> The descriptor based APIs handle active high/low automatically.
> The vbus-gpios are output, request enable while getting the gpio.
> Don't try to get any vbus-gpios for ports outside num-ports.
> 
> WTF? Big sigh.
> 
> Fixes: 054d4b7b577d ("usb: ohci-at91: Use descriptor-based gpio APIs")
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> 
> Hi!
> 
> Resending this, since the only response I've got is that the merge
> window is open and that this patch has been put on hold due to that.
> But I think this regression (which happend between v4.9 and current
> master) should be fixed before the merge window closes.

I don't merge patches before -rc1 comes out, sorry, people should have
tested linux-next better :)

I'll catch up the first week of January, relax.

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use  descriptor-based gpio APIs correctly Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-22 18:30 +0100
  Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use  descriptor-based gpio APIs correctly Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-23 19:10 +0100
    RE: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use  descriptor-based gpio APIs correctly <Wenyou.Yang@microchip.com> - 2016-12-26 06:20 +0100

csiph-web