Re: [PATCH 2/3] xen: return xenstore command failures via response instead of rc

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] xen: return xenstore command failures via response instead of rc
Date	2016-12-22 17:10 +0100
Message-ID	<sRe6l-3cC-9@gated-at.bofh.it> (permalink)
References	<sR5Z8-6ip-13@gated-at.bofh.it> <sR5Z8-6ip-11@gated-at.bofh.it> <sRdWG-2Tv-25@gated-at.bofh.it> <sRdWG-2Tv-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/22/2016 10:55 AM, Juergen Gross wrote:
> On 22/12/16 16:49, Boris Ostrovsky wrote:
>> On 12/22/2016 02:19 AM, Juergen Gross wrote:
>>> When the xenbus driver does some special handling for a Xenstore
>>> command any error condition related to the command should be returned
>>> via an error response instead of letting the related write operation
>>> fail. Otherwise the user land handler might take wrong decisions
>>> assuming the connection to Xenstore is broken.
>> Do we expect the user to always read the reply if no error code was
>> returned?
> Absolutely, yes. This is how error reporting of Xenstore is
> working.

Oh, right --- I was thinking about the string that you are passing back
but not the message type (XS_ERROR).

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Thread

[PATCH 2/3] xen: return xenstore command failures via response instead of rc Juergen Gross <jgross@suse.com> - 2016-12-22 08:30 +0100
  Re: [PATCH 2/3] xen: return xenstore command failures via response  instead of rc Juergen Gross <jgross@suse.com> - 2016-12-22 17:00 +0100
    Re: [PATCH 2/3] xen: return xenstore command failures via response  instead of rc Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-12-22 17:10 +0100
  Re: [PATCH 2/3] xen: return xenstore command failures via response  instead of rc Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-12-22 17:00 +0100

csiph-web