Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1547100
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data |
| Date | 2016-12-24 19:50 +0100 |
| Message-ID | <sRZyh-255-9@gated-at.bofh.it> (permalink) |
| References | <sRXPQ-Xz-5@gated-at.bofh.it> <sRXZv-1gP-9@gated-at.bofh.it> <sRZ5f-1UC-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Saturday 24 December 2016 19:14:21 Pavel Machek wrote:
> On Sat 2016-12-24 17:53:00, Pali Rohár wrote:
> > @@ -1581,10 +1598,16 @@ int wl1251_init_ieee80211(struct wl1251
> > *wl)
> >
> > wl->hw->queues = 4;
> >
> > + if (wl->nvs == NULL && !wl->use_eeprom) {
> > + ret = wl1251_fetch_nvs(wl);
> > + if (ret < 0)
> > + goto out;
> > + }
>
> Is goto out here good idea? IMNSHO it is copy&paste bug, it should
> just proceed with generating random address.
No, goto is correct here. wl1251 cannot be initialized without NVS data.
And when fetching (from userspace) fails it is fatal error.
--
Pali Rohár
pali.rohar@gmail.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] wl1251: Fix MAC address for Nokia N900 Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 18:00 +0100
[PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 18:00 +0100
Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-12-25 21:20 +0100
Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Pali Rohár <pali.rohar@gmail.com> - 2016-12-25 21:50 +0100
Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Pavel Machek <pavel@ucw.cz> - 2016-12-26 16:50 +0100
Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Pali Rohár <pali.rohar@gmail.com> - 2016-12-26 17:10 +0100
Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Pavel Machek <pavel@ucw.cz> - 2016-12-26 17:40 +0100
[PATCH 1/6] firmware: Add request_firmware_prefer_user() function Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 18:00 +0100
[PATCH 3/6] wl1251: Update wl->nvs_len after wl->nvs is valid Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 18:00 +0100
Re: [PATCH 3/6] wl1251: Update wl->nvs_len after wl->nvs is valid Pavel Machek <pavel@ucw.cz> - 2016-12-24 19:10 +0100
[PATCH 4/6] wl1251: Generate random MAC address only if driver does not have valid Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 18:10 +0100
Re: [PATCH 4/6] wl1251: Generate random MAC address only if driver does not have valid Pavel Machek <pavel@ucw.cz> - 2016-12-24 19:10 +0100
Re: [PATCH 4/6] wl1251: Generate random MAC address only if driver does not have valid Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 19:40 +0100
[PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 18:10 +0100
Re: [PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data Pavel Machek <pavel@ucw.cz> - 2016-12-24 19:20 +0100
Re: [PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 19:50 +0100
[PATCH 6/6] wl1251: Set generated MAC address back to NVS data Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 18:10 +0100
Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data Pavel Machek <pavel@ucw.cz> - 2016-12-24 19:20 +0100
Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data Pali Rohár <pali.rohar@gmail.com> - 2016-12-24 19:50 +0100
csiph-web