Re: [PATCH 2/2] efi: efi_mem_reserve(): don't reserve through memblock after mm_init()

From	Nicolai Stange <nicstange@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] efi: efi_mem_reserve(): don't reserve through memblock after mm_init()
Date	2016-12-22 11:30 +0100
Message-ID	<sR8Nk-8fG-3@gated-at.bofh.it> (permalink)
References	<sQTOh-6Uv-11@gated-at.bofh.it> <sQTOh-6Uv-9@gated-at.bofh.it> <sR8Nk-8fG-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Mika Penttilä <mika.penttila@nextfour.com> writes:

> On 21.12.2016 20:28, Nicolai Stange wrote:
>>  /**
>>   * efi_mem_reserve - Reserve an EFI memory region
>> @@ -419,7 +422,7 @@ void __init __weak efi_arch_mem_reserve(phys_addr_t addr, u64 size) {}
>>   */
>>  void __init efi_mem_reserve(phys_addr_t addr, u64 size)
>>  {
>> -	if (!memblock_is_region_reserved(addr, size))
>> +	if (slab_is_available() && !memblock_is_region_reserved(addr, size))
>>  		memblock_reserve(addr, size);
> Maybe !slab_is_available() ?

You're right, thanks for catching this!

Fixed in v2 at http://lkml.kernel.org/r/20161222102340.2689-2-nicstange@gmail.com

Thanks,

Nicolai

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] efi: efi_mem_reserve(): don't reserve through memblock after mm_init() Nicolai Stange <nicstange@gmail.com> - 2016-12-21 19:30 +0100
  Re: [PATCH 2/2] efi: efi_mem_reserve(): don't reserve through memblock after mm_init() Nicolai Stange <nicstange@gmail.com> - 2016-12-22 11:30 +0100

csiph-web