Re: [PATCH v8 3/8] thunderbolt: Communication with the ICM (firmware)

From	Mika Westerberg <mika.westerberg@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 3/8] thunderbolt: Communication with the ICM (firmware)
Date	2016-12-20 09:20 +0100
Message-ID	<sQnOp-33L-11@gated-at.bofh.it> (permalink)
References	<smolj-7YU-3@gated-at.bofh.it> <smolj-7YU-9@gated-at.bofh.it> <sJKPL-58k-1@gated-at.bofh.it> <sQ5eN-7Hq-15@gated-at.bofh.it> <sQ9V7-2r7-19@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Mon, Dec 19, 2016 at 05:21:39PM +0000, Mario.Limonciello@dell.com wrote:
> Dell - Internal Use - Confidential  
> 
> > 
> > There is small problem, though. On non-Apple systems the host controller only
> > appears when something is connected to thunderbolt ports. So the char device
> > would not be there all the time. However, I think we can still notify the
> > userspace by sending an extra uevent when we detect there is a PCIe device or
> > inter-domain connection plugged in.
> > 
> 
> Why couldn't you just create it the first time a device is plugged into a Thunderbolt
> port and leave it until the module is cleaned up?  If the host controller goes to sleep
> an event could be sent to the daemon to let it know it disappeared and not to expect
> data on the char device for now, but leave the node around. 

We don't do that for USB memory sticks (or any other removable media)
either - once you disconnect the device the nodes are also removed. I
suppose same goes with USB network adapters, which is closest to
thunderbolt networking I can think of.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v8 3/8] thunderbolt: Communication with the ICM (firmware) Mika Westerberg <mika.westerberg@intel.com> - 2016-12-19 13:30 +0100
  RE: [PATCH v8 3/8] thunderbolt: Communication with the ICM (firmware) <Mario.Limonciello@dell.com> - 2016-12-19 18:30 +0100
    Re: [PATCH v8 3/8] thunderbolt: Communication with the ICM (firmware) Mika Westerberg <mika.westerberg@intel.com> - 2016-12-20 09:20 +0100

csiph-web