Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1545637
| From | Marek Vasut <marek.vasut@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f |
| Date | 2016-12-21 08:40 +0100 |
| Message-ID | <sQJFf-qS-9@gated-at.bofh.it> (permalink) |
| References | <sQJvz-nE-3@gated-at.bofh.it> <sQJvz-nE-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/21/2016 08:23 AM, John Crispin wrote:
> From: André Valentin <avalentin@marcant.net>
>
> This patch adds support for a new macronix spi flash chip. We have had this
> patch inside our tree for a while and people are actively using routers
> with this chip.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: André Valentin <avalentin@marcant.net>
> ---
> Changes in V2
> * add description
> * add SECT_4K
> * fix indenting
Are you SURE this chip can do sect_4k ? The datasheet seems to imply
that, but I wonder why it wasn't in V1 of this patch then ? Esp. if
people are actively using this chip ...
> drivers/mtd/spi-nor/spi-nor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 171adb3..bfff159 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -868,6 +868,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
> { "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
> { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>
--
Best regards,
Marek Vasut
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f John Crispin <john@phrozen.org> - 2016-12-21 08:30 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f John Crispin <john@phrozen.org> - 2016-12-21 08:40 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f Marek Vasut <marek.vasut@gmail.com> - 2016-12-21 08:40 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f John Crispin <john@phrozen.org> - 2016-12-21 09:20 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f Marek Vasut <marek.vasut@gmail.com> - 2016-12-21 11:10 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f John Crispin <john@phrozen.org> - 2016-12-21 11:20 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f André Valentin <avalentin@marcant.net> - 2016-12-21 09:30 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-12-21 11:30 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f John Crispin <john@phrozen.org> - 2016-12-21 14:20 +0100
Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-12-21 14:40 +0100
csiph-web