Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1543907

Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any

From Jonathan Woithe <jwoithe@just42.net>
Newsgroups linux.kernel
Subject Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any
Date 2016-12-17 02:40 +0100
Message-ID <sPc8F-2S1-9@gated-at.bofh.it> (permalink)
References <sP29j-503-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Dec 16, 2016 at 03:46:03PM +0100, Micha?? K??pie?? wrote:
> The "radio components indicator" LED present in Lifebook E734/E744/E754
> should be lit when any radio transmitter is enabled, so set its default
> trigger to rfkill-any.

This shouldn't cause any problems.  At the end of the day it's only the
default; if for some reason it's inappropriate for any systems we could do
an override.

Acked-by: Jonathan Woithe <jwoithe@just42.net>

> Signed-off-by: Micha?? K??pie?? <kernel@kempniu.pl>
> ---
> Note: the rfkill-any trigger is currently only present in
> mac80211-next/master.
> 
>  drivers/platform/x86/fujitsu-laptop.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 61f39ab..bfc0eb3 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
>  
>  static struct led_classdev radio_led = {
>   .name = "fujitsu::radio_led",
> + .default_trigger = "rfkill-any",
>   .brightness_get = radio_led_get,
>   .brightness_set = radio_led_set
>  };

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any Michał Kępień <kernel@kempniu.pl> - 2016-12-16 16:00 +0100
  Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for  radio LED to rfkill-any Jonathan Woithe <jwoithe@just42.net> - 2016-12-17 02:40 +0100
  Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for  radio LED to rfkill-any Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-12-27 13:00 +0100

csiph-web