Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1540742

Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86
Date 2016-12-13 00:50 +0100
Message-ID <sNIw1-2bW-7@gated-at.bofh.it> (permalink)
References <sMxMl-6wk-27@gated-at.bofh.it> <sMxMl-6wk-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


I have been told I have to send my comments here instead of our
internal ML. I didn't fast enough to comment that during v5. So do it
right now.

On Fri, Dec 9, 2016 at 8:01 PM, Irina Tirdea <irina.tirdea@intel.com> wrote:
> The pmc_atom driver does not contain any architecture specific
> code. It only enables the SOC Power Management Controller Driver

SOC -> SoC
Driver -> driver

> for BayTrail and CherryTrail platforms.
>
> Move the pmc_atom driver from arch/x86/platform/atom to
> drivers/platform/x86.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> ---
>  arch/x86/Kconfig                                                     | 4 ----
>  arch/x86/platform/atom/Makefile                                      | 1 -
>  drivers/acpi/acpi_lpss.c                                             | 2 +-
>  drivers/platform/x86/Kconfig                                         | 4 ++++
>  drivers/platform/x86/Makefile                                        | 1 +
>  {arch/x86/platform/atom => drivers/platform/x86}/pmc_atom.c          | 3 +--

>  {arch/x86/include/asm => include/linux/platform_data/x86}/pmc_atom.h | 0

No, it's not a *platform data*.

Other that that looks good to me.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-12-13 00:50 +0100
  Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to  drivers/platform/x86 Darren Hart <dvhart@infradead.org> - 2016-12-16 19:30 +0100
    Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-12-16 19:40 +0100

csiph-web