Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539954

Re: [GIT PULL] readlink cleanup

Show all headers | View raw

On Sat, Dec 10, 2016 at 09:41:45PM +0100, Miklos Szeredi wrote:
> Hi Al,
> 
> Please pull from:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git readlink
> 
> This is a rework of the readlink cleanup patchset.  Now readlink(2) does the
> following:
> 
>  - if i_op->readlink() is non-NULL (only proc and afs mountpoints for now) then
>    it calls that;
>  - otherwise call i_op->get_link();
>  - signature of ->readlink() now matches that of ->get_link();
> 
> This is against the #misc branch (the stats look better that way ;)

I'm still not sure what does "vfs: convert ->readlink to same signature as
->get_link" buy us.  If anything, the result appears to be more complex -
you make freeing that buffer delayed (and introduce a dynamically allocated
buffer in one case that didn't use it)...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] readlink cleanup Miklos Szeredi <miklos@szeredi.hu> - 2016-12-10 21:50 +0100
  Re: [GIT PULL] readlink cleanup Al Viro <viro@ZenIV.linux.org.uk> - 2016-12-11 03:40 +0100
    Re: [GIT PULL] readlink cleanup Al Viro <viro@ZenIV.linux.org.uk> - 2016-12-11 03:40 +0100
      Re: [GIT PULL] readlink cleanup Miklos Szeredi <miklos@szeredi.hu> - 2016-12-11 11:10 +0100

csiph-web