Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1539305

Re: [PATCH 06/20] hwmon/via-cputemp: Convert to hotplug state machine

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 06/20] hwmon/via-cputemp: Convert to hotplug state machine
Date 2016-12-09 13:00 +0100
Message-ID <sMs0h-2MT-9@gated-at.bofh.it> (permalink)
References <sEzLj-4lB-7@gated-at.bofh.it> <sEzV0-4p4-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Guenter,

On Thu, 17 Nov 2016, Sebastian Andrzej Siewior wrote:

> Install the callbacks via the state machine and let the core invoke the
> callbacks on the already online CPUs. When the hotplug state is
> unregistered the cleanup function is called for each cpu. So both cpu loops
> in init() and exit() are not longer required.

Can we please get those two VIA patches merged for 4.10? They are blocking
the final removal of the CPU hotplug notifier crap.

The first one which removes that loop is really harmless as there are no
multisocket VIAs. Heterogenous cores in a single die would be surprising
and the loop check would be the least of our worries in that case. IOW, it
would never get so far...

The one converting the notifier is not changing any of the functionality.

I cannot test on all VIA SMP variants either, but at least on the one I
have access to it just works.

Thanks,

	tglx

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 06/20] hwmon/via-cputemp: Convert to hotplug state  machine Thomas Gleixner <tglx@linutronix.de> - 2016-12-09 13:00 +0100
  Re: [PATCH 06/20] hwmon/via-cputemp: Convert to hotplug state machine Guenter Roeck <linux@roeck-us.net> - 2016-12-09 19:20 +0100
    Re: [PATCH 06/20] hwmon/via-cputemp: Convert to hotplug state  machine Thomas Gleixner <tglx@linutronix.de> - 2016-12-09 19:40 +0100

csiph-web