Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over 0xff

From	Radim Krčmář <rkrcmar@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over 0xff
Date	2016-12-06 14:00 +0100
Message-ID	<sLnvH-29V-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <sL2AV-5Jq-5@gated-at.bofh.it> <sL402-6Jc-5@gated-at.bofh.it> <sL5Sa-7U6-29@gated-at.bofh.it> <sL8wG-Xr-29@gated-at.bofh.it> <sLkxQ-hE-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-12-06 10:37+0100, David Hildenbrand:
>> I think the agreement is to embrace compatibility, so we pile new
>> mistakes to hide known ones.
>> (Rewriting the past requires far more power than accepting it:
>>  If we didn't force unfixed kernels out of existence, then userspace
>>  couldn't tell if hotplug up to high VCPU ID limit is supported.)
> 
> I agree, the question is how old the bug is (you should know better than me
> :) )

Just half a year old, since v4.7.

>      and if introducing a capability is strictly necessary. Do we have to do
> the check in QEMU or can we simply fix implementations out there silently.

This fix is too big for stable and I don't think that patches outside of
stable get backported much.

> (especially as hotplugging cpuid > 255 doesn't sound like setups wildly used
> already today - and it doesn't work ;) ).

Yes, it seems that no-one using high APIC ID noticed/cared.

>                                           But as I said, I don't know the
> history, so you decide if this check in QEMU is necessary.

QEMU can decide not to check (I actually expect it won't :]).
I think the option to check is worth two lines of code in KVM, though.

> Fix all QEMUs (introduce capability check) vs fix all relevant kernels
> (limiting VCPU id to 255).

APID ID over 255 works without hotplug and has few users, so lowering
the limit would regress cases that are more important, IMO.

Thread

[PATCH 0/4] KVM: x86: allow hotplug of VCPU with APIC ID over 0xff Radim Krčmář <rkrcmar@redhat.com> - 2016-12-02 20:50 +0100
  [PATCH 2/4] KVM: x86: replace kvm_apic_id with kvm_{x,x2}apic_id Radim Krčmář <rkrcmar@redhat.com> - 2016-12-02 20:50 +0100
  [PATCH 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same Radim Krčmář <rkrcmar@redhat.com> - 2016-12-02 20:50 +0100
  [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over 0xff Radim Krčmář <rkrcmar@redhat.com> - 2016-12-02 20:50 +0100
    Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over  0xff David Hildenbrand <david@redhat.com> - 2016-12-05 15:40 +0100
      Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over  0xff Radim Krčmář <rkrcmar@redhat.com> - 2016-12-05 17:10 +0100
        Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over  0xff David Hildenbrand <david@redhat.com> - 2016-12-05 19:10 +0100
          Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over  0xff Radim Krčmář <rkrcmar@redhat.com> - 2016-12-05 22:00 +0100
            Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over  0xff David Hildenbrand <david@redhat.com> - 2016-12-06 10:50 +0100
              Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over  0xff Radim Krčmář <rkrcmar@redhat.com> - 2016-12-06 14:00 +0100
    Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over  0xff Paolo Bonzini <pbonzini@redhat.com> - 2016-12-07 13:10 +0100
      Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over  0xff Radim Krčmář <rkrcmar@redhat.com> - 2016-12-07 16:50 +0100

csiph-web