Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537977

[tip:perf/core] perf sched: Cleanup option processing

Show all headers | View raw

Commit-ID:  6fa94258ce2673adc707b2ec5668464f2cf83ed3
Gitweb:     http://git.kernel.org/tip/6fa94258ce2673adc707b2ec5668464f2cf83ed3
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 6 Dec 2016 12:40:01 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 7 Dec 2016 12:00:33 -0300

perf sched: Cleanup option processing

The -D/--dump-raw-trace option is in the parent option so no need to
repeat it.  Also move -f/--force option to parent as it's common to
handle data file.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20161206034010.6499-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-sched.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 84c39f1..634d8cf 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -2583,6 +2583,7 @@ static int perf_sched__timehist(struct perf_sched *sched)
 	struct perf_data_file file = {
 		.path = input_name,
 		.mode = PERF_DATA_MODE_READ,
+		.force = sched->force,
 	};
 
 	struct perf_session *session;
@@ -2988,6 +2989,7 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
 		    "be more verbose (show symbol address, etc)"),
 	OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
 		    "dump raw trace in ASCII"),
+	OPT_BOOLEAN('f', "force", &sched.force, "don't complain, do it"),
 	OPT_END()
 	};
 	const struct option latency_options[] = {
@@ -2995,8 +2997,6 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
 		   "sort by key(s): runtime, switch, avg, max"),
 	OPT_INTEGER('C', "CPU", &sched.profile_cpu,
 		    "CPU to profile on"),
-	OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
-		    "dump raw trace in ASCII"),
 	OPT_BOOLEAN('p', "pids", &sched.skip_merge,
 		    "latency stats per pid instead of per comm"),
 	OPT_PARENT(sched_options)
@@ -3004,9 +3004,6 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
 	const struct option replay_options[] = {
 	OPT_UINTEGER('r', "repeat", &sched.replay_repeat,
 		     "repeat the workload replay N times (-1: infinite)"),
-	OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
-		    "dump raw trace in ASCII"),
-	OPT_BOOLEAN('f', "force", &sched.force, "don't complain, do it"),
 	OPT_PARENT(sched_options)
 	};
 	const struct option map_options[] = {

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET 00/10] perf sched timehist: Introduce --idle-hist option (v1) Namhyung Kim <namhyung@kernel.org> - 2016-12-06 04:50 +0100
  [PATCH 01/10] perf sched: Cleanup option processing Namhyung Kim <namhyung@kernel.org> - 2016-12-06 04:50 +0100
    Re: [PATCH 01/10] perf sched: Cleanup option processing David Ahern <dsahern@gmail.com> - 2016-12-06 05:00 +0100
    [tip:perf/core] perf sched: Cleanup option processing tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-12-07 19:30 +0100
  [PATCH 02/10] perf tools: Introduce callchain_cursor__copy() Namhyung Kim <namhyung@kernel.org> - 2016-12-06 04:50 +0100
    [tip:perf/core] perf callchain: Introduce callchain_cursor__copy() tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-12-07 19:30 +0100
  Re: [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist  option (v1) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-06 20:50 +0100
    Re: [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist  option (v1) David Ahern <dsahern@gmail.com> - 2016-12-06 22:50 +0100

csiph-web