Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1535448
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd |
| Date | 2016-12-03 17:20 +0100 |
| Message-ID | <sKlcC-3CC-3@gated-at.bofh.it> (permalink) |
| References | <sGBIZ-2TX-5@gated-at.bofh.it> <sGBJ0-2TX-53@gated-at.bofh.it> <sKkzT-36C-13@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Sat, Dec 03, 2016 at 05:32:36PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > > Functions tpm_transmit and transmit_cmd are referenced > > from other functions kdoc hence deserve documentation. > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > Do you mind if I change TPM_DIGEST_SIZE to SHA1_DIGEST_SIZE? > > I'm looking to drop TPM_DIGEST_SIZE eventually. > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> ... in the sense that the changes do not break the compilation and do not produce sparse or cocciheck errors. I guess that should be enough for documentation changes. /Jarkko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-03 16:40 +0100
Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-03 17:20 +0100
Re: [tpmdd-devel] [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd Nayna <nayna@linux.vnet.ibm.com> - 2016-12-06 10:20 +0100
RE: [tpmdd-devel] [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-12-06 13:20 +0100
csiph-web