Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535409

[PATCH] uio: uio_cif: Fix style issues

Show all headers | View raw

- Update header-file inclusion path.
- Fix indentation of switch and case.
- Remove extra space in function calls.

Signed-off-by: ChinmayVS <cvs268@gmail.com>
---
 drivers/uio/uio_cif.c | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/drivers/uio/uio_cif.c b/drivers/uio/uio_cif.c
index 30f533c..4acad98 100644
--- a/drivers/uio/uio_cif.c
+++ b/drivers/uio/uio_cif.c
@@ -14,7 +14,7 @@
 #include <linux/slab.h>
 #include <linux/uio_driver.h>
 
-#include <asm/io.h>
+#include <linux/io.h>
 
 #define PLX9030_INTCSR		0x4C
 #define INTSCR_INT1_ENABLE	0x01
@@ -67,16 +67,20 @@ static int hilscher_pci_probe(struct pci_dev *dev,
 	info->mem[1].addr = pci_resource_start(dev, 2);
 	info->mem[1].size = pci_resource_len(dev, 2);
 	info->mem[1].memtype = UIO_MEM_PHYS;
+
 	switch (id->subdevice) {
-		case CIF_SUBDEVICE_PROFIBUS:
-			info->name = "CIF_Profibus";
-			break;
-		case CIF_SUBDEVICE_DEVICENET:
-			info->name = "CIF_Devicenet";
-			break;
-		default:
-			info->name = "CIF_???";
+	case CIF_SUBDEVICE_PROFIBUS:
+		info->name = "CIF_Profibus";
+		break;
+
+	case CIF_SUBDEVICE_DEVICENET:
+		info->name = "CIF_Devicenet";
+		break;
+
+	default:
+		info->name = "CIF_???";
 	}
+
 	info->version = "0.0.1";
 	info->irq = dev->irq;
 	info->irq_flags = IRQF_SHARED;
@@ -95,7 +99,7 @@ static int hilscher_pci_probe(struct pci_dev *dev,
 out_disable:
 	pci_disable_device(dev);
 out_free:
-	kfree (info);
+	kfree(info);
 	return -ENODEV;
 }
 
@@ -108,7 +112,7 @@ static void hilscher_pci_remove(struct pci_dev *dev)
 	pci_disable_device(dev);
 	iounmap(info->mem[0].internal_addr);
 
-	kfree (info);
+	kfree(info);
 }
 
 static struct pci_device_id hilscher_pci_ids[] = {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] uio: uio_cif: Fix style issues ChinmayVS <cvs268@gmail.com> - 2016-12-03 15:20 +0100
  Re: [PATCH] uio: uio_cif: Fix style issues Greg KH <gregkh@linuxfoundation.org> - 2016-12-03 18:20 +0100

csiph-web