[PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

From	Eric Engestrom <eric@engestrom.ch>
Newsgroups	linux.kernel
Subject	[PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path
Date	2016-12-05 01:00 +0100
Message-ID	<sKORj-5fp-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

90d27a1 moved the lock before this error path but forgot to add an
unlock here.

Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread")
Cc: Pei Zhang <pei.zhang@intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
---
 drivers/gpu/drm/i915/gvt/scheduler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index f898df3..cd13c4b 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -177,6 +177,7 @@ static int dispatch_workload(struct intel_vgpu_workload *workload)
 	rq = i915_gem_request_alloc(dev_priv->engine[ring_id], shadow_ctx);
 	if (IS_ERR(rq)) {
 		gvt_err("fail to allocate gem request\n");
+		mutex_unlock(&dev_priv->drm.struct_mutex);
 		workload->status = PTR_ERR(rq);
 		return workload->status;
 	}
-- 
Cheers,
  Eric

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path Eric Engestrom <eric@engestrom.ch> - 2016-12-05 01:00 +0100
  Re: [PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s  error path Zhenyu Wang <zhenyuw@linux.intel.com> - 2016-12-05 03:50 +0100

csiph-web