Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1534801

Re: [PATCH 1/1] dma: ioat: set error code on failures

Show all headers | View raw

On Thu, Dec 01, 2016 at 03:10:12PM +0800, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188591. In function
> ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
> value of return variable err is 0 (indicates no error). As a result, the
> return value may be inconsistent with the execution status. This patch
> fixes the bug by assigning -ENOMEM to err on the error path.

Please describe the fix you are doing. For Bugzilla you can use Fixes tag

Also add the correct subsystem tag, so the changelog can look like:

dmaengine: ioat: set error code on failures

In ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
value of return variable err is 0 ...

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188591
Fixes: Commit you fixes

..

So please update the changelog and resend with Acks collected

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] dma: ioat: set error code on failures Pan Bian <bianpan2016@163.com> - 2016-12-01 08:20 +0100
  Re: [PATCH 1/1] dma: ioat: set error code on failures Dave Jiang <dave.jiang@intel.com> - 2016-12-01 17:50 +0100
  Re: [PATCH 1/1] dma: ioat: set error code on failures Vinod Koul <vinod.koul@intel.com> - 2016-12-02 11:30 +0100

csiph-web