Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531683

Re: [PATCH 1/1] libnvdimm, namespace: fix the type of name variable

Show all headers | View raw

On Sat, Nov 26, 2016 at 08:18:04PM +0100, Nicolas Iooss wrote:
> In create_namespace_blk(), the local variable "name" is defined as an
> array of NSLABEL_NAME_LEN pointers:
> 
>     char *name[NSLABEL_NAME_LEN];
> 
> This variable is then used in calls to memcpy() and kmemdup() as if it
> were char[NSLABEL_NAME_LEN]. Remove the star in the variable definition
> to makes it look right.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

Yep, nice catch.

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] libnvdimm, namespace: fix the type of name variable Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-11-26 20:20 +0100
  Re: [PATCH 1/1] libnvdimm, namespace: fix the type of name variable Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-11-28 22:30 +0100

csiph-web