Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning
Date	2016-11-26 02:00 +0100
Message-ID	<sHzvr-7Sd-5@gated-at.bofh.it> (permalink)
References	<sGMEp-1gq-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 23 Nov 2016 22:48:19 +0200

> I would appreciate review to confirm the function doesn't
> do anything unsafe though.
> 
> In particular, should this use __hlist_for_each_rcu instead?
> I note that __hlist_for_each_rcu does rcu_dereference
> internally, which is missing here.

I personally think it should use __hlist_for_each_rcu, otherwise
nothing expresses the rcu-ness of the operation.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning David Miller <davem@davemloft.net> - 2016-11-26 02:00 +0100
  Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-28 15:40 +0100
    Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning "Michael S. Tsirkin" <mst@redhat.com> - 2016-11-28 16:40 +0100
    Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-05 04:50 +0100
  Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-05 04:30 +0100

csiph-web