Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530180

Re: [PATCH 5/7] efi: Get the secure boot status [ver #3]

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 5/7] efi: Get the secure boot status [ver #3]
Date 2016-11-25 13:50 +0100
Message-ID <sHo70-CC-35@gated-at.bofh.it> (permalink)
References (3 earlier) <sH8bT-76f-5@gated-at.bofh.it> <sHliN-7iy-11@gated-at.bofh.it> <sHlsu-7lD-25@gated-at.bofh.it> <sHnuh-m5-5@gated-at.bofh.it> <sHnND-wd-9@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> Yes. In pre-2.6, DeployedMode is not a reserved name, and so it may be
> possible for someone to slip in a DeployedMode=0 on a secure boot
> enabled system to trick the kernel into thinking lockdown should be
> disabled.

How does one get the version number?  Unfortunately, searching the document
for 'version' doesn't help as every page has that in the footer:-/

> > +               if (val == 1)
> > +                       return 0;
> 
> I think the logic is the wrong way around here. Secure Boot is enabled
> if SecureBoot=1 and SetupMode=0, unless DeployedMode=0. So you should
> return 0 here if val == 0, but only when running on 2.6 or later.

Good point.

David

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] efi: Pass secure boot mode to kernel [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 14:00 +0100
  [PATCH 2/7] x86/efi: Allow invocation of arbitrary runtime services  [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 14:00 +0100
  [PATCH 4/7] efi: Add SHIM and image security database GUID  definitions [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 14:00 +0100
  [PATCH 7/7] efi: Add EFI_SECURE_BOOT bit [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 14:00 +0100
  [PATCH 1/7] efi: use typed function pointers for runtime services  table [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 14:00 +0100
  [PATCH 6/7] efi: Disable secure boot if shim is in insecure mode  [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 14:00 +0100
  [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 14:00 +0100
    Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-11-24 20:50 +0100
      Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-25 10:50 +0100
        Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-25 11:00 +0100
          Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-25 13:10 +0100
            Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-25 13:30 +0100
              Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-25 13:50 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-25 13:50 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-25 14:10 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-25 14:30 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-25 14:10 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-25 15:00 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-25 17:00 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-25 18:00 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] David Howells <dhowells@redhat.com> - 2016-11-25 18:00 +0100
                Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-25 18:00 +0100
  [PATCH 3/7] arm/efi: Allow invocation of arbitrary runtime services  [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 14:00 +0100

csiph-web