Re: [v7] QE: remove PPCisms for QE

From	Scott Wood <oss@buserror.net>
Newsgroups	linux.kernel
Subject	Re: [v7] QE: remove PPCisms for QE
Date	2016-11-23 08:40 +0100
Message-ID	<sGAjT-1SC-1@gated-at.bofh.it> (permalink)
References	<sGAjT-1SC-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 28, 2016 at 11:15:31AM +0800, Zhao Qiang wrote:
> QE was supported on PowerPC, and dependent on PPC,
> Now it is supported on other platforms. so remove PPCisms.
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---

Changelog should be something like:

soc/fsl/qe: Cleanups and portability fixes

QE was supported on PowerPC, and dependent on PPC.  In preparation for
supporting on other platforms, remove some PPCisms.

The PPC kconfig dependency is moved from the QE core into the individual
QE peripheral drivers, to allow portability work to occur on them
separately.
    
> diff --git a/include/soc/fsl/qe/qe.h b/include/soc/fsl/qe/qe.h
> index 70339d7..f7a14f2 100644
> --- a/include/soc/fsl/qe/qe.h
> +++ b/include/soc/fsl/qe/qe.h
> @@ -21,7 +21,6 @@
>  #include <linux/spinlock.h>
>  #include <linux/errno.h>
>  #include <linux/err.h>
> -#include <asm/cpm.h>
>  #include <soc/fsl/qe/immap_qe.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>

When building corenet32_smp_defconfig, I get this:

/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:262:31: error: 'BD_SC_READY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:266:31: error: 'BD_SC_WRAP' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:348:3: error: 'BD_SC_READY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:350:31: error: 'BD_SC_WRAP' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:477:16: error: 'BD_SC_EMPTY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:9: error: 'BD_SC_BR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:20: error: 'BD_SC_FR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:31: error: 'BD_SC_PR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:42: error: 'BD_SC_OV' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:512:3: error: 'BD_SC_ID' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:514:31: error: 'BD_SC_WRAP' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:605:26: error: 'BD_SC_EMPTY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:605:40: error: 'BD_SC_INTRPT' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:613:25: error: 'BD_SC_WRAP' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:926:27: error: 'BD_SC_EMPTY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:926:41: error: 'BD_SC_OV' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:928:29: error: 'BD_SC_FR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:928:40: error: 'BD_SC_PR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:930:29: error: 'BD_SC_BR' undeclared (first use in this function)

-Scott

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [v7] QE: remove PPCisms for QE Scott Wood <oss@buserror.net> - 2016-11-23 08:40 +0100

csiph-web